Bootstrap 3 support

[levraipixel]

Hi there,

First of all, thanks for this amazing project: it's wonderful.
I was thinking about creating a bootstrap-3-compatible branch: is it something you guys are already working on ? If not, should I fork from the 1.10 branch or from the 2.0 ?
Best

[GBH]

No, nobody is secretly working on bootstrap 3 compatibility just yet. CMS actually doesn't use bootstrap grid system. However form builder needs updating. See: https://github.com/comfy/formatted_form
FormattedForm needs to be adjusted to use BS3 markup... and its version bumped to 3.0.

If you want to give it a stab that would be awesome.

[levraipixel]

Still, there are some buttons here an there that need a btn-default class, like in https://github.com/comfy/comfortable-mexican-sofa/blob/master/app/views/admin/cms/pages/index.html.haml for instance.
I'll take a look at the form builder but it seems like a not-so-tiny task to adapt it to BS3.

[GBH]

Yeah, form builder is the 90% of the work. Should be pretty straightforward though. It's just changing markup in like 2 partial files. Let me know if you have any questions.

[levraipixel]

like _field_block and _field_inline ?

[GBH]

Yeap, those are the ones.

[levraipixel]

Ok I'll give it a try, then.

[hesham]

Is there anyone working on this?

[Emerson]

Also interested in seeing this happen.

[levraipixel]

I might work on it, but not before a week or two from now

[gretel]

uh i did think about using bootstrap 3 with cms - so thats not compatible for now?
@GBH, any alternative approaches you can think of? my reason for bootstrap 3 is that designer like it. and as designers generally like CMS.. that seems lika good catch to me.

[Emerson]

@gretel - right now we're using Bootstrap 2.3, but are looking forward to upgrading to Bootstrap 3. It's a fairly trivial task, we just haven't gotten around to it yet. If there is no movement on this soon I'll look into it myself.

[gretel]

ah ok so i can just go ahead and either wait or commit myself :) thanks

[mrwokkel]

This is a great opportunity to split the bootstrap css from the comfy specific css.
Maybe even allow for variables (scss)

[Emerson]

Update:

@GBH has been looking into this a little more and it turns out that it's not as easy as we first believed. Our current form helper might need to be swapped out for something more bootstrap friendly.

@rubylibre - agreed. The more separation the better.

[Emerson]

Bootstrap 3 is almost ready for prime time. You can check it out on the 1.12 branch. I've been using it on my project and things mostly seem OK.

You'll likely need to update your routes and controllers to account for the updated namespace that we are now using.

[GBH]

Everything is in master branch now. Added dependency on bootstrap-sass and bootstrap_form replaces old formatted_form.

[gretel]

development looks fine.. now deploying.. thanks!

tom hensel
office +49-4022869965
mobile +49-15735234208

On 04.05.2014, at 19:30, Oleg notifications@github.com wrote:

Everything is in master branch now. Added dependency on bootstrap-sass and bootstrap_form replaces old formatted_form.

—
Reply to this email directly or view it on GitHub.