Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register extensions execute all js files #3332

Open
grzegorzewskiflyingdog opened this issue Apr 24, 2024 · 1 comment
Open

register extensions execute all js files #3332

grzegorzewskiflyingdog opened this issue Apr 24, 2024 · 1 comment

Comments

@grzegorzewskiflyingdog
Copy link

Now new custom_nodes extensions execute all JavaScript files under extension directory, and all sub directorys.
this is code rsponsible for this:

 @routes.get("/extensions")
        async def get_extensions(request):
            files = glob.glob(os.path.join(
                glob.escape(self.web_root), 'extensions/**/*.js'), recursive=True)

i think this would be better to execute only one js start entry point, or not execute js in subdirectory, or create some special directory where js will be not executed, in other case i have a problem with workingwith my other projects js files which should not be bootstraped automatically by application.

@geroldmeisinger
Copy link

same here.

another user manually copies files to lib directory in install_nodes:
https://github.com/AlekPet/ComfyUI_Custom_Nodes_AlekPet/blob/master/__init__.py#L143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants