-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spandrel addition brakes restoration nodes using GFPGAN models #3594
Comments
So it broke after a commit that deleted all of the code? 17,700+ deletions... I wonder why it's not working right. Just kidding. It was a very large change, that replaced comfy functions with spandrel, and Im going to assume the issue is probably with spandrel, the code in the commit looks okay to me, at cursory glance without tracing the execution. The actual code changes besides using spandrel are quite minor (considering 17k lines were deleted), and load from state dict is pretty universal, so I'd say it's probably a bug in spandrel related to that particular model. This is the only real change. out = model_loading.load_state_dict(sd).eval() to the spandrel version out = ModelLoader().load_from_state_dict(sd).eval() outside of that the only change is upscale_model.to("cpu") which updates upscale_model.cpu() to use the currently preferented syntax with pytorch. |
thanks for posting this, I will wait for the update! |
same problem, |
Any idea when this is going to be fixed? <3 my workflow stopped working :( |
You can temporarily roll back to the commit ffc4b7c
when you want to return back - just switch the branch to master
|
It worked for me! Thanks! |
It's not a problem with spandrel. Previous code required images normalized to -1 +1 range. Spandrel models universally require 0..1 range. |
This is an english language repo, please keep comments in english so that other people may benefit from them. |
thx working |
Hello! |
Fixed Gourieff/comfyui-reactor-node@a7ae669 |
Hi guys!
When we try to restore any image with GFPGAN using face restoration nodes - we get a gray noise above the restored image
Issue appeared after this commit 8cfd677
Related Issue: Gourieff/comfyui-reactor-node#326
The text was updated successfully, but these errors were encountered: