Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SDL files (.graphql) as schema files #61

Closed
LasseRosenow opened this issue Dec 26, 2019 · 6 comments
Closed

Allow SDL files (.graphql) as schema files #61

LasseRosenow opened this issue Dec 26, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@LasseRosenow
Copy link
Contributor

If you use the graphql Playground, it is very easy do download the graphql schema as a .graphql file in the SDL format. This format is very clean an nice to use compared to the introspection schema which is annoying to query and so on..

So it would be very nice to support this.

#8 already mentioned something like this

@comigor comigor added the enhancement New feature or request label Dec 26, 2019
@comigor
Copy link
Owner

comigor commented Dec 26, 2019

Hey there @lazylazyllama!

Absolutely! I've started the project parsing the .json file because it was easier to parse in the code.

@klavs
Copy link
Contributor

klavs commented Dec 29, 2019

@comigor, I'm experimenting with code generation from GraphQL documents in gql-dart/gql#15
It's not yet finished and it will not be compatible with artemis, but feel free to use or steel the code from there.

@vasilich6107
Copy link
Collaborator

vasilich6107 commented Feb 8, 2020

@comigor I'm starting the implementation of this ticket)
I hope to finish fast. The main idea is to remove the intermediate representation of schema and move to the gql ast usage.

@comigor
Copy link
Owner

comigor commented Feb 8, 2020

Oh nice, looking forward to this!

@klavs
Copy link
Contributor

klavs commented Feb 8, 2020

@vasilich6107 would you mind building it as a separate "introspection json to gql ast" package?

That way the community will be able to use it for their own use cases and Artemis would benefit from community giving feedback and improving your package.

@vasilich6107
Copy link
Collaborator

@klavs
I do not see any use case from introspection json -> gql benefits in real life)
Personally I didn't know about the existence of JSON introspection before using artemis package. Could be my bad)

As I mentioned in my previous PR the JSON introspection usage + internal intermediate representation makes hard to support tests. This is the reason why I'm investing in this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants