Network connection via libp2p sometimes fails because it connects to the wrong address

[thomaseizinger]

Note: Bug originally perceived by @D4nte.

The connection to the other node sometimes fails because we are trying to connect via an external address (if connected to VPN for example).

I believe, this has to do with the order in which we return the addresses here:

comit-rs/application/comit_node/src/libp2p_bam/behaviour.rs

Lines 131 to 140 in 0e787c9

	fn addresses_of_peer(&mut self, peer_id: &PeerId) -> Vec<Multiaddr> {
	self.addresses()
	.find_map(|(candidate, addresses)| {
	if &candidate == peer_id {
	Some(addresses)
	} else {
	None
	}
	})
	.unwrap_or_else(Vec::new)

Needs further investigation:

1. if this is the source of the perceived bug
2. what the correct/expected order is

[bonomat]

@D4nte try to reproduce this please.

[D4nte]

cargo make e2e passes on Mac OS with vpn on.