Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup test setup when watching for balance in production #217

Closed
da-kami opened this issue Feb 22, 2021 · 1 comment
Closed

Cleanup test setup when watching for balance in production #217

da-kami opened this issue Feb 22, 2021 · 1 comment

Comments

@da-kami
Copy link
Member

da-kami commented Feb 22, 2021

With #216 we added a loop to make sure the wallet has caught up with the balance in the test setup.

Once we implement watching for deposit #196 we should remove the code added by #216 and ensure we use the production code for waiting for the balance to catch up.

@thomaseizinger
Copy link
Contributor

This seems to be no longer valid.

The premise was that we might be able to re-use the 'watch for deposit' functionality but that turned out not to be true, hence closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants