Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading lists showing comics as "This comic is scheduled for processing", despite all comics fully processed. #165

Closed
bareheiny opened this issue Feb 29, 2020 · 7 comments
Assignees
Labels
bug Something isn't working reading list Issues relating to reading lists
Milestone

Comments

@bareheiny
Copy link

bareheiny commented Feb 29, 2020

As per subject. A reading list with four comics is showing all four as scheduled for processing - despite all comics in the library being fully processed.

CX version: 0.5.0-0.1

  1. Start CX with no existing library and log in.

  2. Search for comics to import, select 50 and begin the import.

  3. Wait for all comics to be fully imported.

  4. Create reading list and add 4 comics to it.

  5. Open reading list - all covers displayed with spinning circle overlay, and “scheduled for processing” pop out text is displayed.

reading lists

Note all comics are fully processed, and the CX log shows no sign of processing (generating hashes and so forth).

Opening a comic from the reading lists shows all metadata is loaded, however selecting all and starting the scrape process displays the "Series name is required" and "Issue # is required" messages.

@mcpierce mcpierce added the reading list Issues relating to reading lists label Feb 29, 2020
@mcpierce mcpierce added this to the 0.6 milestone Feb 29, 2020
@mcpierce
Copy link
Contributor

I'm pretty sure this is related to the comic, when it finishes processing, not causing the ReadingListEntry object related to it to be returned.

@mcpierce mcpierce assigned mcpierce and unassigned mcpierce Mar 11, 2020
@mcpierce
Copy link
Contributor

mcpierce commented May 4, 2020

@bareheiny Can you verify if this issue still exists? And, if not, please close this issue. Thanks.

@bareheiny
Copy link
Author

I can't figure out how to create / modify / access reading lists in the latest dev build.

@mcpierce
Copy link
Contributor

mcpierce commented May 5, 2020 via email

@mcpierce mcpierce modified the milestones: 0.6, 0.7 May 31, 2020
@mcpierce mcpierce added the bug Something isn't working label Jun 5, 2020
@mcpierce mcpierce modified the milestones: 0.7, 0.6 Jun 5, 2020
@mcpierce
Copy link
Contributor

mcpierce commented Jun 7, 2020

@bareheiny The fix for this is in rc7. The steps to verify it are:

  1. start importing some comics
  2. immediately go to the library page and select some of those importing comics
  3. click on an already-imported comic (the context menu doesn't popup now on those still importing) to add selected comics to a reading list
  4. go to that reading list and watch the imports process as expected

@mcpierce mcpierce self-assigned this Jun 9, 2020
@bareheiny
Copy link
Author

Right, so this is largely working - but I'm seeing some odd behavior

The pop-out menu doesn't appear for importing comics. Deselecting it (by de-selecting all selected comics), and adding an already imported comic to a reading list results in the importing comic being added once it's imported....but not the select (and previously imported) comic.

I'll do a re-import on some larger comis to get the steps in the next day or so.

@bareheiny
Copy link
Author

Nope, can't replicate.

Everything seems to be working as intended / expected - so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working reading list Issues relating to reading lists
Projects
None yet
Development

No branches or pull requests

2 participants