Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Order for Recipient/Organization in German Postal Format #34

Closed
mariuswilms opened this issue May 21, 2015 · 3 comments
Closed

Comments

@mariuswilms
Copy link

When both recipient and org are present the german addresses seem incorrectly formatted. In Germany postal addresses have the organization come before the recipient.

bildschirmfoto 2015-05-21 um 12 23 19
According to Deutsche Post

However it seems odd that Google might be wrong here:
https://github.com/commerceguys/addressing/blob/master/resources/address_format/DE.json
http://i18napis.appspot.com/address/data/DE

In case this is just me getting the semantics wrong, feel free to close the ticket.
Thanks for the great library!

@jonathanmaron
Copy link

I can confirm this: The company name comes on line 1 and the recipient on line 2, when printing an address block in Germany. Just yesterday, did I notice that the order is incorrect. Is Germany unique in this regard?

@bojanz
Copy link
Contributor

bojanz commented May 22, 2015

A grep through the dataset shows 28 countries that put the organization on the first line, including Austria, Belgium, France, Netherlands, Switzerland.
So, Germany is not unique here. The error in Google's dataset is probably caused by UPU being unclear about this: http://www.upu.int/fileadmin/documentsFiles/activities/addressingUnit/deuEn.pdf

I've opened a bug report in the libaddressinput issue queue: google/libaddressinput#83

I've created a lot of issues in their queue, and they're being resolved very slowly (one in the past 6 months) so I'm going to start maintaining our own patch against the dataset, and include this fix.

@bojanz
Copy link
Contributor

bojanz commented May 26, 2015

The fix will be applied in PR #36.

I think we're done here. Thanks, everyone.

@bojanz bojanz closed this as completed May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants