You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When both recipient and org are present the german addresses seem incorrectly formatted. In Germany postal addresses have the organization come before the recipient.
I can confirm this: The company name comes on line 1 and the recipient on line 2, when printing an address block in Germany. Just yesterday, did I notice that the order is incorrect. Is Germany unique in this regard?
A grep through the dataset shows 28 countries that put the organization on the first line, including Austria, Belgium, France, Netherlands, Switzerland.
So, Germany is not unique here. The error in Google's dataset is probably caused by UPU being unclear about this: http://www.upu.int/fileadmin/documentsFiles/activities/addressingUnit/deuEn.pdf
I've created a lot of issues in their queue, and they're being resolved very slowly (one in the past 6 months) so I'm going to start maintaining our own patch against the dataset, and include this fix.
When both recipient and org are present the german addresses seem incorrectly formatted. In Germany postal addresses have the organization come before the recipient.
According to Deutsche Post
However it seems odd that Google might be wrong here:
https://github.com/commerceguys/addressing/blob/master/resources/address_format/DE.json
http://i18napis.appspot.com/address/data/DE
In case this is just me getting the semantics wrong, feel free to close the ticket.
Thanks for the great library!
The text was updated successfully, but these errors were encountered: