-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #2600564: Integrate profile into commerce #269
Conversation
Since we're providing the field ourselves, can we name it address instead of field_address? |
38cb4ef
to
4886e42
Compare
@bojanz corrected. |
bundle: billing | ||
label: Address | ||
description: '' | ||
required: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be required :)
Almost there! |
49f608b
to
7994400
Compare
c8a39ee
to
ee5436d
Compare
@bojanz corrected :) is it okay now? |
e126ab0
to
8c79d1e
Compare
Almost there! You added methods to the Order entity, but not to the OrderInterface. Did those changes get lost by mistake? |
->setRequired(TRUE) | ||
->setSetting('target_type', 'profile') | ||
->setSetting('handler', 'default') | ||
->setTranslatable(TRUE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need a ->setSetting('handler_settings', ['target_bundles' => ['profile']]); This will limit the reference field to the appropriate bundle.
ee5436d
to
bbbab5a
Compare
@bojanz changes made. |
@@ -151,4 +151,40 @@ public function getEmail(); | |||
*/ | |||
public function setEmail($mail); | |||
|
|||
/** | |||
* Get billing profile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verbs in docblocks must be in the third person. "Gets the billing profile."
bbbab5a
to
0d5ccc9
Compare
@bojanz comment corrected :) |
0d5ccc9
to
447a0e8
Compare
447a0e8
to
6e07c89
Compare
Issue #2600564: Integrate profile into commerce
This will cover: