Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common interface for ApiMethods #126

Closed
xferra opened this issue Jan 18, 2022 · 3 comments
Closed

Common interface for ApiMethods #126

xferra opened this issue Jan 18, 2022 · 3 comments
Labels
Customer issue enhancement New feature or request

Comments

@xferra
Copy link

xferra commented Jan 18, 2022

Is your feature request related to a problem? Please describe.

Hello,
I'm in the progress of migrating from v1 to v2.
When using v1 I was able to perform generic operations on different Objects using CommandBuilder<>. As for now - different API methods have their own (the same) implementation for Query, Limit, Offset, etc., and there is no common interface for that.

Example:
Carts.Limit
Order.Limit

Describe the solution you'd like
Introduce an interface for Expand, Sort, Limit, Offset, etc., and if possible for ExecuteAsync too.

Describe alternatives you've considered
None.

Additional context
None.

@xferra xferra added the enhancement New feature or request label Jan 18, 2022
@jenschude
Copy link
Contributor

With 26e4fc2 we introduced now common interfaces. Will be added to the next release

@jenschude
Copy link
Contributor

jenschude commented May 24, 2022

With the next release the SDK will include some Interfaces which includes parameters like Sort, Limit etc.

Please see

https://github.com/commercetools/commercetools-dotnet-core-sdk-v2/pull/158/files

Manual written ones like ById, ByGet etc will come in a later release

@jenschude
Copy link
Contributor

3.2.0 with this change has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer issue enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants