You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The method addPredicateVar in the various request classes has 2 overloads: one that support List types, another one for everything else.
Last week, it happened to me that I passed a Collection type to addPredicateVar method. Unfortunately, this then links to the overloaded method
public XXX addPredicateVar(final String varName,
final TValue predicateVar)
which will just invoke toString on the collection, instead of adding a variable for each member of the collection.
Describe the solution you'd like
I suggest to change the template that generates the method
public XXXX addPredicateVar(final String varName,
final List predicateVar)
to
public <TValue> XXXX addPredicateVar(final String varName,
final **Collection**<TValue> predicateVar)
instead. Same for the "withPredicateVar" method. It should be a backwards compatible change. I don't see any semantic requirement for only supporting Lists.
Thank you for your support!
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
The method addPredicateVar in the various request classes has 2 overloads: one that support List types, another one for everything else.
Last week, it happened to me that I passed a Collection type to addPredicateVar method. Unfortunately, this then links to the overloaded method
public XXX addPredicateVar(final String varName,
final TValue predicateVar)
which will just invoke toString on the collection, instead of adding a variable for each member of the collection.
Describe the solution you'd like
I suggest to change the template that generates the method
public XXXX addPredicateVar(final String varName,
final List predicateVar)
to
instead. Same for the "withPredicateVar" method. It should be a backwards compatible change. I don't see any semantic requirement for only supporting Lists.
Thank you for your support!
The text was updated successfully, but these errors were encountered: