Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why create this, without any issues or PRs to enzyme itself? #8

Closed
ljharb opened this issue Oct 10, 2018 · 7 comments
Closed

Why create this, without any issues or PRs to enzyme itself? #8

ljharb opened this issue Oct 10, 2018 · 7 comments

Comments

@ljharb
Copy link

@ljharb ljharb commented Oct 10, 2018

While until has been under consideration since long before enzyme 3, I don't recall any issues asking for any of the features in this repo.

Is there any particular reason there was no attempt to add these features to enzyme proper?

@tdeekens
Copy link
Contributor

@tdeekens tdeekens commented Oct 10, 2018

Is there any particular reason there was no attempt to add these features to enzyme proper?

Not really. We wanted to ensure that the solutions work for us, then see how valuable it is to others and then propose them as an addition to enzyme itself. If you have interest in us adding this to enzyme itself we're more than happy to help out.

@emmenko
Copy link
Member

@emmenko emmenko commented Oct 10, 2018

We're happy to contribute to enzyme of course, if you think this might be a consider. Thanks for reaching out to us! 🙌

@ljharb
Copy link
Author

@ljharb ljharb commented Oct 10, 2018

I think each one should be evaluated independently, but if you’ve found them useful, it’s always helpful to discuss the use cases. A package like this shouldn’t be necessary (in an ideal world) - enzyme should be able to meet the needs of its users on its own.

@dferber90
Copy link
Contributor

@dferber90 dferber90 commented Oct 11, 2018

I now opened enzymejs/enzyme#1863 which enhances enzyme with renderProp, the most useful method of this package.

We're currently using renderProp ~320 times in our tests. The other methods (drill and until) didn't really gain adoption internally, so I did not open PRs to enzyme for them.

With that, this issue seems ready to be closed. Thanks again for reaching out! We'd be excited if this makes it into enzyme!

@dferber90
Copy link
Contributor

@dferber90 dferber90 commented Nov 6, 2018

With enzymejs/enzyme#1863 being merged now, I'll close this. Thanks again for reaching out!

@dferber90 dferber90 closed this Nov 6, 2018
@emmenko
Copy link
Member

@emmenko emmenko commented Nov 6, 2018

Cool!! 💯

@ljharb
Copy link
Author

@ljharb ljharb commented Nov 6, 2018

I look forward to discussing the other pieces as well :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants