New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why create this, without any issues or PRs to enzyme itself? #8
Comments
Not really. We wanted to ensure that the solutions work for us, then see how valuable it is to others and then propose them as an addition to enzyme itself. If you have interest in us adding this to enzyme itself we're more than happy to help out. |
We're happy to contribute to enzyme of course, if you think this might be a consider. Thanks for reaching out to us! 🙌 |
I think each one should be evaluated independently, but if you’ve found them useful, it’s always helpful to discuss the use cases. A package like this shouldn’t be necessary (in an ideal world) - enzyme should be able to meet the needs of its users on its own. |
I now opened enzymejs/enzyme#1863 which enhances We're currently using With that, this issue seems ready to be closed. Thanks again for reaching out! We'd be excited if this makes it into |
With enzymejs/enzyme#1863 being merged now, I'll close this. Thanks again for reaching out! |
Cool!! 💯 |
I look forward to discussing the other pieces as well :-) |
While
until
has been under consideration since long before enzyme 3, I don't recall any issues asking for any of the features in this repo.Is there any particular reason there was no attempt to add these features to enzyme proper?
The text was updated successfully, but these errors were encountered: