Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message should include any product identifier #142

Closed
lojzatran opened this issue Dec 10, 2018 · 1 comment
Closed

Error message should include any product identifier #142

lojzatran opened this issue Dec 10, 2018 · 1 comment
Assignees
@lojzatran
Labels
Type: Enhancement

Comments

@lojzatran
Copy link
Contributor

Description

When error is thrown, it should also include product ID, variant SKUs or keys or any other identifier so it's possible to uniquely identify the error product. Currently this is missing here:
https://github.com/sphereio/sphere-product-import/blob/master/lib/product-import.coffee#L316
@lojzatran lojzatran self-assigned this Dec 10, 2018
@junajan
Copy link
Contributor

junajan commented Dec 10, 2018

I would go with variant SKU as there can be no product ID which can be logged.

@lojzatran lojzatran mentioned this issue Dec 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lojzatran lojzatran

Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lojzatran @junajan @VasumathiJayakumar