Build / Integrate a GHA approval workflow

[dtoki]

See Comment: #238 (comment)
Parent Issue: #238

[dtoki]

@commitdev/zero

Working on the approval step for GHA & Zero, GitHub does not have an explicit approval workflow mechanism for promoting a successful stage deploy to prod. I have two possible solutions, both possible:

1. A new issue is open if the stage build is successful with the changelogs and links to a GHA prod deployment workflow the user manually triggers.

2. A GH bot comment on the open pr if the stage build is successful, and links to a GHA prod deployment workflow the user manually triggers.

What do you guys think is the better approach here?

[bmonkman]

2 sounds better to me. What does the "manually triggers" step look like though? Is it as easy as just clicking the link in the comment from the bot?

[dtoki]

Looks like this -> then click on run workflow.

[bmonkman]

Sounds like that might be okay. Maybe try it out and let's see how it feels?

[dtoki]

Here's how it feels
dtoki-test-org/frontend-11111#1

[bmonkman]

The text looks like this:

Deploy to production

Staging S3 Sync: ⚙️success
Manually trigger production deployment here

I would say the header should be something "Staging Deployment Complete"
Then we should list a couple of the build steps along with "s3 sync" with their status like building artifact, tests
Also when clicking the "here" link I just see the production deploys page with nothing on it. How does someone run the production workflow from there?

[dtoki]

Right 👍🏽! the text there is just a placeholder; having the build step details is probably a good idea!
you have to click Run Workflow -> Run Workflow

I think it might also be useful to also include a visual aid in the comment like 👇

[dtoki]

I'm changing the workflow to use the build artifact and not clone the repo, should be up in a bit...

Seems like you have to use the API to download an artifact from a diffrent workflow.

actions/upload-artifact#62 (comment)