Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to provide Git config or disable it #10

Closed
jcrqr opened this issue Aug 29, 2021 · 1 comment · Fixed by #11
Closed

Allow to provide Git config or disable it #10

jcrqr opened this issue Aug 29, 2021 · 1 comment · Fixed by #11

Comments

@jcrqr
Copy link
Contributor

jcrqr commented Aug 29, 2021

Description

This action setups Git automatically for the user which is nice in most use-cases but decreases customisation in certain workflows.

For example, one might want to use a custom GitHub App's as the commiter, so he/her can add extra validations around it and more easily audit what workflows are doing what across multiple repositories.

Possible Solutions

  • Allow the user to pass git_name and git_email inputs or default to GitHub Action's ones
    or
  • Allow the user to pass a setup_git flag to toggle this feature and setup git before running the action

If this sounds a reasonable feature for you, I can create a PR adding it.

Thanks in advance!

@jcrqr jcrqr changed the title Allow to provide Git config Allow to provide Git config or disable it Aug 29, 2021
@woile
Copy link
Member

woile commented Aug 29, 2021

Sounds good! I like it, feel free to create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants