Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this action is installing commitizen == 1.0.0 if the project pinned tomlkit dependency != 0.5.3 #5

Closed
diefans opened this issue Dec 2, 2020 · 3 comments

Comments

@diefans
Copy link

diefans commented Dec 2, 2020

I want to point out, that the assertion/hope that a sane project puts deployment/dev dependencies into its production requirements (requirements.txt) cannot be hold: https://github.com/commitizen-tools/commitizen-action/blob/master/entrypoint.sh#L21-L23

IMHO commitizen should install plugins from a specific file, but must not use requirements.txt. Project dependencies must not suffer from or be twisted by tool dependencies.

@woile
Copy link
Member

woile commented Dec 2, 2020

Agreed! I didn't think about that.

@woile
Copy link
Member

woile commented Dec 2, 2020

@diefans I've pushed a new change, could you test and check everything is ok?

Thanks!

@woile woile closed this as completed Dec 3, 2020
@diefans
Copy link
Author

diefans commented Dec 3, 2020

sorry to be late, but seems to work now... tanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants