Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: move codespell configuration to pyproject.toml #1136

Merged
merged 2 commits into from
May 23, 2024

Conversation

yarikoptic
Copy link
Contributor

@yarikoptic yarikoptic commented May 21, 2024

Description

So people could just run "codespell" without pre-commit and have centralized configuration for tools (the others are already in pyproject.toml)

Checklist

  • [N/A] Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test

I did ;)

❯ ./scripts/format
+ poetry run python -m ruff format commitizen tests
/home/yoh/venvs/dev3.11/bin/python: No module named ruff
❯ ./scripts/test
ImportError while loading conftest '/home/yoh/proj/misc/commitizen/tests/conftest.py'.
tests/conftest.py:10: in <module>
    from pytest_mock import MockerFixture
E   ModuleNotFoundError: No module named 'pytest_mock'
  • Test the changes on the local machine manually
  • Update the documentation for the changes

@Lee-W
Copy link
Member

Lee-W commented May 22, 2024

@yarikoptic You'll need to run poetry install first before running ./scripts/test and ./scripst/format

So people could just run "codespell" without pre-commit and have centralized configuration for tools (the others are already in pyproject.toml)

Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (120d514) to head (2a1118e).
Report is 343 commits behind head on master.

Current head 2a1118e differs from pull request most recent head fd65982

Please upload reports for the commit fd65982 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
+ Coverage   97.33%   97.54%   +0.20%     
==========================================
  Files          42       55      +13     
  Lines        2104     2487     +383     
==========================================
+ Hits         2048     2426     +378     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.54% <ø> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W
Copy link
Member

Lee-W commented May 22, 2024

@yarikoptic According to the CI, it seems poetry.lock is not ignored in this setup. Could you please take a look? Thanks!

@yarikoptic
Copy link
Contributor Author

That's done, will need to fix up commit message now when wake up

… is in pyproject.toml

Signed-off-by: Yaroslav Halchenko <debian@onerussian.com>
@yarikoptic
Copy link
Contributor Author

done, green now

@Lee-W Lee-W merged commit 26dc450 into commitizen-tools:master May 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants