New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use existing message #3
Comments
@raibutera Great idea. One thing we need to consider is that you can do this in git:
If someone uses this format in |
weird, github formatting issue, see the following comment |
the -m flagIn my personal opinion, users of cz-cli would probably expect that the multiple -m flagsAs a result, passing in multiple A more sensible implementation would just combine the three passed messages (truncated to 100 char total) and insert that into the short message. This is the easiest solution to implement quickly anyway. So Commitizen Specific FlagsThere's also no real reason why we couldn't implement extra, commitizen specific flags. NB: we should just take extra care to avoid conflicts with existing git commit flags. (Except for Commizen Specific Flags Suggestion
maybe we can add shorthand aliases for type, scope, body and notes, ie: Prompt BehaviourI don't really see the point in passing in messages via flag of the user still has to use the wizard-like prompt. It's less friction to just not pass anything at all than have to remember the order in which the messages were passed. That's the main complaint I have with the {m1}/{m2}/{m3} idea. Example of Suggested BehaviourComplete (All Flags)Input this would produce
Incomplete (1+ flags missing)If I reran the same command as above but, for example, omitted the |
Thanks for laying this out in an organized way. I like the idea and I think we can probably make this work with the current system of allowing adapters to coexist for various conventions. Most of what you're talking about should be implemented in the cz-conventional-changelog adapter repo even though any future adapter could certainly implement the same functionality since the cz-cli is really just a thin wrapper. |
I am closing this for now and have opened an issue with the cz-conventional-changelog adapter since that is really where this issue belongs. The only part of this issue that the cli can assist with is the passing of raw and/or parsed arguments into the adapters' prompter method. I don't really expect that this getting completed until I finalize a versioned programmatic adapter spec. |
if git cz is passed the argument -m then that message should be passed to the "short imperative tense description of the change"
The text was updated successfully, but these errors were encountered: