Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty lines in commit message #373

Closed
brokenmass opened this issue Oct 28, 2016 · 3 comments
Closed

Empty lines in commit message #373

brokenmass opened this issue Oct 28, 2016 · 3 comments

Comments

@brokenmass
Copy link

brokenmass commented Oct 28, 2016

If a commit message generated by a prompter contains new lines (\n) , commitizen split those across multiple -m commands generating erroneous empty lines in the comment
https://github.com/commitizen/cz-cli/blob/master/src/git/commit.js#L17

original message (and expected result)

perf: remove graphiteWidth option

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas id pulvinar mi, 
at porttitor dolor. Vivamus id ultricies tellus. Sed fringilla massa a urna venenatis 
sodales. Morbi mattis aliquam dui tempor efficitur. Maecenas ut velit at enim 
imperdiet convallis.

BREAKING CHANGE: The graphiteWidth option has been removed. 
The default graphite width of 10mm is always used for performance reason.

Issues: #1234

gets committed as :

perf: remove graphiteWidth option

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Maecenas id pulvinar mi, 

at porttitor dolor. Vivamus id ultricies tellus. Sed fringilla massa a urna venenatis 

sodales. Morbi mattis aliquam dui tempor efficitur. Maecenas ut velit at enim 

imperdiet convallis.

BREAKING CHANGE: The graphiteWidth option has been removed. 

The default graphite width of 10mm is always used for performance reason.

Issues: #1234

this issue occurred from version 2.8.3 where gulp-git was removed.
on version 2.8.2 the output is correct

I strongly suggest to don't split the commit in multiple -m instructions as that would the formatting imposed by the prompter and eventually lead to a wrongly parsed (by conventional changelog) commit message, but instead just rely on parser correctness

@brokenmass
Copy link
Author

any updates on this issue ?

@jimthedev
Copy link
Member

Thanks I'll look into this.

@jimthedev
Copy link
Member

Ok I think this takes care of it. We need to wait until the CI tests run, but I'll ask you to check on it once the next version is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants