Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version #8

Closed
kentcdodds opened this issue Oct 8, 2015 · 15 comments
Closed

Release new version #8

kentcdodds opened this issue Oct 8, 2015 · 15 comments

Comments

@kentcdodds
Copy link
Member

This needs to be released. Do you have any problem with me doing that? I'll do it in 10 minutes if you don't respond!!! 🕚 💣

@kentcdodds
Copy link
Member Author

I'm confused. The latest version in master's package.json states it's version 1.1.0, but the latest version on npm is 1.1.2, and the tag on github has a package.json with 1.1.2 and was released just 2 weeks ago but doesn't have the fix in it which happened 3 weeks ago...

What kind of operation are you running here Jim!? :P

@kentcdodds
Copy link
Member Author

I'll tell you what. I'll set up semantic-release and publish-latest on this repo, then everything will be better.

@kentcdodds
Copy link
Member Author

Hey @jimthedev, could you add @commtizen-bot to the owners on the org and https://www.npmjs.com/~commitizen-bot to the collaborators on npm? Thanks!

@kentcdodds
Copy link
Member Author

Forget about npm, I got that working. Just need to add @commitizen-bot to the org. Thanks!

@jimthedev
Copy link
Member

Hey, sorry Kent. I've been sick on and off for the past month so I'm a bit behind and clearly missed something here. Thanks for catching it.

Here is a quick update:

  • Commitizen-bot has been added on npm
  • I want to implement all of the changes you talk about in your library egghead series.
  • I've started a complete rewrite of cz-cli including a full test suite. It is slow going but includes the ability to run commitizen init which will npm install the adapter and edit package.json to include the dependency.
  • The version in package.json of this adapter is obviously wrong. My guess is I missed a push.

Thanks for lending a hand. :)

@kentcdodds
Copy link
Member Author

That all sounds amazingly awesome. Could you add the @commitizen-bot account to the github org so it can push tagged releases?

@jimthedev
Copy link
Member

Invite sent!

@kentcdodds
Copy link
Member Author

It was a bit bumpy, but everything's set now! @commitizen-bot is at our command :-)

@kentcdodds
Copy link
Member Author

Unfortunately, I'm still getting this error when using this with angular-formly :-(

Potentially unhandled rejection [3] Error: Error loading "word-wrap" at file:/Users/kentcdodds/Developer/formly-js/angular-formly/node_modules/cz-conventional-changelog/word-wrap.js
Error loading "word-wrap" from "index" at file:/Users/kentcdodds/Developer/formly-js/angular-formly/node_modules/cz-conventional-changelog/index.js
ENOENT: no such file or directory, open '/Users/kentcdodds/Developer/formly-js/angular-formly/node_modules/cz-conventional-changelog/word-wrap.js'
at Error (native)

No idea what's up... I'm using npm@3...

@jimthedev
Copy link
Member

It is npm3. It moves around packages which unfortunately breaks some of the assumptions that cz makes about the filesystem. I am working on a fix that takes this into account as part of 2.0 which includes a CI test suite.

@jimthedev
Copy link
Member

2.0 is also written in ES6 w/ Babel so you'll be right at home @kentcdodds

@kentcdodds
Copy link
Member Author

Awesome! I recommend you checkout the way add-to-path is built and released. Writing your stuff in ES6 is awesome, automatically building and releasing it is even cooler! Just check out the scripts and the .travis.yml

@jimthedev
Copy link
Member

Sounds good @kentcdodds. I expect it to be ready for review in the next few days or so. Once I get all of that integrated would you be willing to do a final review?

@kentcdodds
Copy link
Member Author

Sure!

@jimthedev
Copy link
Member

high five gang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants