Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Sentence validation gets stuck sometimes. #4091

Closed
HarikalarKutusu opened this issue Jun 23, 2023 · 8 comments
Closed

[BUG] Sentence validation gets stuck sometimes. #4091

HarikalarKutusu opened this issue Jun 23, 2023 · 8 comments
Labels

Comments

@HarikalarKutusu
Copy link
Contributor

Describe the bug
During sentence validation, sometimes YES/NO buttons do not work. The small green popup saying Yes/No appears but the record does advance.
After a page refresh, it might work, sometimes even this does not work.

Video

Click for a short OSB video presenting the issue.

Desktop or Mobile (please complete the following information):

  • OS: Windows 10x64
  • Browser: Tried on the latest Chrome flavors only (Opera, Vivaldi, etc)
@HarikalarKutusu
Copy link
Contributor Author

OK, when this happens, if I wait for a while and try hitting the buttons, it works.

It seems like rate-limiting. Is there any?

If so the limit needs some adjustment. If each sentence has a couple of words one can read it in a couple of seconds and make a decision.

@moz-rotimib
Copy link
Contributor

Hello, @HarikalarKutusu thanks for reporting this issue.

Next time you get this error could you send a screenshot of your browser dev tools? There should be an error message there and that could help us to figure out what could be causing this. Thanks

@HarikalarKutusu
Copy link
Contributor Author

Here it is (the first 3 are from my ad-blocker), it is rate-limiting as I mentioned above.

image

One can rapidly check many short sentences and/or obvious spam sentences (e.g. from another language or bad resource).

Or think of this scenario: In our workflow, I check each sentence one by one - and multiple times! But I want it to be checked by one other person - to reach our 0 error goal. I add my sentences and want to give the first vote (as OK). I add 100 such sentences but with rate-limited voting 10/min, I have to spend 10-15 min to give the first vote.

Bülent

@moz-rotimib
Copy link
Contributor

@HarikalarKutusu Thanks for the screenshot and the comments. As you said this seems to be an issue with rate limiting and we will look into possible solutions for this.

@HarikalarKutusu
Copy link
Contributor Author

This should be fixed by #4118 ... Closing

@kwikwag
Copy link
Contributor

kwikwag commented Jul 23, 2023

I think this should remain open until there is a pull request which displays an error once the rate limit is reached.

@HarikalarKutusu
Copy link
Contributor Author

@kwikwag, you are right. Maybe a feature request is in order...

It has been a pain.
I have several thousand sentences imported, from which only ~10% can be acceptable (unprocessed support chat dump).
I'm sure some of that junk got into the dataset.

@HarikalarKutusu
Copy link
Contributor Author

The error message is here with the new v1.101.0 release. In fact, with 30 sentences/min I could not hit that wall either.

https://github.com/common-voice/common-voice/releases/tag/release-v1.101.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants