Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] expose api to request for micorophone, and a callback for when we have it. #44

Closed
mikehenrty opened this issue May 21, 2017 · 4 comments
Assignees

Comments

@mikehenrty
Copy link
Member

We could even attach the permission prompt to the first time I call "start_capture".

@mikehenrty
Copy link
Member Author

@andrenatal or @mbebenita, would either of you be able to have a look?

@mikehenrty
Copy link
Member Author

The reason I think this is important is because I think Apply looks at UX in their decision making process, and prompting for a mic without user action is bad UX.

@andrenatal
Copy link
Contributor

@mikehenrty This was fixed here. So now the permission request is handled when you call start_capture.

I also introduced a new callback to send messages to the webapp so those can be displayed properly to the user.

@andrenatal
Copy link
Contributor

andrenatal commented May 26, 2017

@mikehenrty Currently are being sent the following messages:

  • errorplaying: if the audio file could not be played
  • capturestarted: when the mic starts recording
  • errorrecording: when some error happened when started recording
  • nomicpermission: when the user denied permission to record

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants