Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_characters in rules #182

Closed
HarikalarKutusu opened this issue Jun 13, 2023 · 3 comments
Closed

max_characters in rules #182

HarikalarKutusu opened this issue Jun 13, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed rules rust Pull requests that update Rust code

Comments

@HarikalarKutusu
Copy link
Contributor

I'm trying to make this work with Turkish.
I see the following:

min_trimmed_length = 
min_word_count = 
max_word_count = 
min_characters =

If I'm not mistaken, there is no max_characters setting. Like in German, Turkish words have a high variance in length due to the agglutinative nature of the language. So, a 5-6 word sentence can be quite long while reading.

I've been also planning to change the sentence-collector rules to use charter length instead of words, but I can see that it is missing here.

If this is true, can this be added?
@MichaelKohler
Copy link
Member

I think that sounds reasonable to be implemented. I'd suggest to implement this the same way as min_characters, including a test for it and documentation in the README.

Thanks for bringing this up.

@MichaelKohler MichaelKohler added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers rules rust Pull requests that update Rust code labels Jun 13, 2023
@MichaelKohler MichaelKohler changed the title max_characters in rules? max_characters in rules Jun 13, 2023
@HarikalarKutusu
Copy link
Contributor Author

OK, I'll do it tomorrow on a clean clone (I've been messing with the current one)...

@HarikalarKutusu HarikalarKutusu mentioned this issue Jun 13, 2023
Merged
@HarikalarKutusu
Copy link
Contributor Author

Implemented with #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed rules rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelKohler @HarikalarKutusu