Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.x support for schema_salad #108

Closed
11 tasks done
manu-chroma opened this issue May 17, 2017 · 4 comments
Closed
11 tasks done

Python 3.x support for schema_salad #108

manu-chroma opened this issue May 17, 2017 · 4 comments

Comments

@manu-chroma
Copy link
Member

manu-chroma commented May 17, 2017

Get passing test locally (tox) and on travis CI in python 3.x environment

Checklist:

  • python-avro support
  • use fixers like modernize and futurize to fix basic issues
  • integrate six library (majority done)
  • handle string literals properly: u" " or from __future__ import unicode_literals (optional for the time being)
  • mypy goals
    • update to latest version of mypy for --py2 mode
    • run in python3 mode
    • now using Text inplace of unicode in existing codebase
    • Add stub files for 3rd party libraries and stdlib to typeshed/3 and typeshed/2.7: Status
    • update Makefile
  • edit .travis.yml, simplify tox.ini
@manu-chroma
Copy link
Member Author

@tetron @mr-c im confused between using u" " or from __future__ import unicode_literal for handling strings. currently reading up on it.
Would like your thoughts on what might be a better way to go.

@kapilkd13
Copy link
Contributor

kapilkd13 commented May 23, 2017

Hi, I am adding few steps from my proposal. You have implemented almost all of them, still, I hope you find this useful.

  • Text versus binary data
  • We would also include a test in our test suite that checks if all dependencies are compatible with Python 3 or not [dropping this since we've already used caniusepython3 to verify dependency compatibility with python3. will be doing (obvious) manual checking when adding a new dependency in the future, thus making this redundant]
  • Changing source code of cwltool and schema-salad as per Python 3 standard ex. print to print(), using a script like Futurize.
  • Issues like “Division operator”
  • Checking for dependencies which prevent our transition to Python 3 using tools like caniusepython3.

@manu-chroma
Copy link
Member Author

manu-chroma commented May 23, 2017

Hey @kapilkd13, I've updated your comment to be in checklist form so I can tick mark whatever is done. Thanks btw.

@mr-c
Copy link
Member

mr-c commented Aug 9, 2017

Done, thanks!

@mr-c mr-c closed this as completed Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants