Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google reply format change ? #3

Open
iXo opened this issue Mar 16, 2023 · 6 comments
Open

Google reply format change ? #3

iXo opened this issue Mar 16, 2023 · 6 comments

Comments

@iXo
Copy link

iXo commented Mar 16, 2023

Hi,

since the v0.4.2 I can now use this crate, thanks, but it seems that the way Google is now replying prevent for it to works :

11:54:08 [DEBUG] (52) hyper::client::connect::dns: resolving host="www.google.com"
11:54:08 [DEBUG] (48) hyper::client::connect::http: connecting to 142.250.179.68:443
11:54:08 [DEBUG] (48) hyper::client::connect::http: connected to 142.250.179.68:443
11:54:08 [DEBUG] (26) hyper::proto::h1::io: flushed 217 bytes
11:54:08 [DEBUG] (26) hyper::proto::h1::io: read 2764 bytes
11:54:08 [DEBUG] (26) hyper::proto::h1::io: parsed 23 headers
11:54:08 [DEBUG] (26) hyper::proto::h1::conn: incoming body is empty
11:54:08 [DEBUG] (50) hyper::client::pool: pooling idle connection for ("https", www.google.com)
Error: Unable to parse images from json. Google may have changed the way their data is stored

Is it just me ?

@joshuajbouw
Copy link

I can't get it to work as well. It returns no image urls, or downloads anything.

@Dr-42
Copy link

Dr-42 commented Apr 28, 2023

Same issue here. I use your package as a dependency in my project.

@commonkestrel
Copy link
Owner

commonkestrel commented Apr 28, 2023

Yep, looks like Google changed where source is stored. I should be able to push an update tonight. Sorry for taking so long to get around to this.

@commonkestrel
Copy link
Owner

A fix should be up, let me know if it doesn't fix it.

@Dr-42
Copy link

Dr-42 commented Apr 28, 2023

Yes it works now. Thank you

@FlooferLand
Copy link

FlooferLand commented Dec 28, 2023

@commonkestrel Getting this error on the latest 0.4.3! Google seems to have changed something again, error happens when calling image_search::urls for both sync and async. My log is the same as iXo's besides the changed numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants