Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<p> instead <H1> in first line (utf-8-BOM) #334

Closed
ghost opened this issue Mar 3, 2020 · 3 comments
Closed

<p> instead <H1> in first line (utf-8-BOM) #334

ghost opened this issue Mar 3, 2020 · 3 comments

Comments

@ghost
Copy link

ghost commented Mar 3, 2020 •
edited by ghost

If header 1 level (# Header) in first line,
I get <p> # Header</p> instead <H1>Header</H1>.
@jgm
Copy link
Member

jgm commented Mar 3, 2020

Can't reproduce.
Are you sure you have a space between # and H?

@ghost
Copy link
Author

ghost commented Mar 3, 2020 •
edited by ghost

Hello, John.
Yes, I do all right, according to specification.
I compared different md-files and found (it seems to me) the cause of the issue. This is UTF-8-BOM.
What is your opinion on whether utf-8-BOM should be supported?

@jgm
Copy link
Member

jgm commented Mar 3, 2020 •
edited

Ah yes -- we should presumably skip a BOM marker at the beginning of input. That would be a worthwhile change.

@ghost ghost changed the title <p> instead <H1> <p> instead <H1> (utf-8-BOM) Mar 3, 2020
@ghost ghost changed the title <p> instead <H1> (utf-8-BOM) <p> instead <H1> in first line (utf-8-BOM) Mar 3, 2020
@jgm jgm closed this as completed in 74e8f63 Mar 3, 2020
zwaldowski referenced this issue in zwaldowski/cmark-gfm Dec 22, 2020
@zwaldowski
Skip UTF-8 BOM if present at beginning of buffer.
9b3f5d3 
Closes github#334.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgm