Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape pipe in code section of table leaves escape character #149

Closed
jawscout opened this issue Feb 1, 2019 · 6 comments · Fixed by #157
Closed

Escape pipe in code section of table leaves escape character #149

jawscout opened this issue Feb 1, 2019 · 6 comments · Fixed by #157

Comments

@jawscout
Copy link
Contributor

jawscout commented Feb 1, 2019

Escaping a pipe in the code section of a table keeps the escape character when the spec shows that it shouldn't.

Steps to reproduce the problem (provide example input):

| f\|oo  |
| ------ |
| b `\|` az |
| b **\|** im |

Expected behavior:

<table>
<thead>
<tr>
<th>f|oo</th>
</tr>
</thead>
<tbody>
<tr>
<td>b <code>|</code> az</td>
</tr>
<tr>
<td>b <strong>|</strong> im</td>
</tr></tbody></table>

Actual behavior:

<table>
<thead>
<tr><th>f|oo</th></tr>
</thead>
<tbody>
<tr><td>b <code>\|</code> az</td></tr>
<tr><td>b <strong>|</strong> im</td></tr>
</tbody>
</table>

Links:
https://github.github.com/gfm/#example-193

@robinst
Copy link
Collaborator

robinst commented Feb 4, 2019

Hey, thanks for the good bug report! There's an open issue about checking our extension against the spec (the spec didn't exist when the extension was originally written), I guess this is one of the issues.

I'm currently on holiday but will take a look when I'm back. If you feel like it, have a look at the code, it should not be too difficult to fix :).

@viceice
Copy link

viceice commented Jul 11, 2019

Any news? This is a really annoying bug.

@robinst
Copy link
Collaborator

robinst commented Jul 12, 2019

Working on this on a new branch: https://github.com/atlassian/commonmark-java/compare/issue-149-gfm-table-spec-changes?expand=1

@robinst
Copy link
Collaborator

robinst commented Jul 15, 2019

Merged, will be in the next release (0.13.0).

@viceice
Copy link

viceice commented Jul 15, 2019

Any estimate for the next release?

@robinst
Copy link
Collaborator

robinst commented Jul 16, 2019

Now 😄

https://twitter.com/niborst/status/1150946272976621569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants