Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly show that the license text is a link #1037

Closed
sivaraam opened this issue Jan 1, 2018 · 12 comments
Closed

Explicitly show that the license text is a link #1037

sivaraam opened this issue Jan 1, 2018 · 12 comments

Comments

@sivaraam
Copy link
Member

sivaraam commented Jan 1, 2018

I saw the blog post about the recent release and came to know that the licenses were linked. I thought of seeing it in the app and was surprised to see that the text denoting the license was plain. Surprisingly tapping on the text did open the browser make it behave like links while not visually depicting a link. That wasn't something I expected (Principle of least surprise). I might not have even found it was a link if I hadn't read the blog post. I guess it's better to give links their usual distinction (like other links on the same screen).

screenshot_2018-01-01-20-20-16

I guess there are two ways to go about it,

  1. Really make it a link
  2. Give it a link like appearance.
@sivaraam
Copy link
Member Author

sivaraam commented Jan 1, 2018

Regardless, I think the Upload screen needs a revamp. It's quite odd to show the image being uploaded in the background. It seems to be cluttering up with the text in the screen (the text Wikimedia Commons policies is barely visible). It would be better to show a small preview of the image and let the users see it fully if they want to.

@misaochan
Copy link
Member

Explicitly displaying the license link sounds good to me. Please do create a separate issue to discuss the Upload screen revamp. :)

@mithlesh4257
Copy link

I like to work on this issue.

@nicolas-raoul
Copy link
Member

@mithlesh4257 It is yours, waiting for your pull request :-)

@madhurgupta10
Copy link
Collaborator

@nicolas-raoul If the issue is still not solved then I would love to work on it.

@nicolas-raoul
Copy link
Member

@madhurgupta10 No news from @mithlesh4257 so yes, feel free!
Please inform us of your progress every few days.

@madhurgupta10
Copy link
Collaborator

@nicolas-raoul Sure.

@AmineToualbi
Copy link

Is someone working on this?

@nicolas-raoul
Copy link
Member

@madhurgupta10 What is the situation on this?

@Mansi449
Copy link
Contributor

@nicolas-raoul can I work on this issue?

@nicolas-raoul
Copy link
Member

@Mansi449 How about letting @AmineToualbi (who expressed interest 6 days ago) work on it?
@AmineToualbi No news from madhurgupta10 so it is yours, looking forward to your pull request :-)

@domdomegg
Copy link
Member

Fixed in new upload UI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants