Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"about rate us" message is empty #1333

Closed
amire80 opened this issue Mar 18, 2018 · 17 comments
Closed

"about rate us" message is empty #1333

amire80 opened this issue Mar 18, 2018 · 17 comments

Comments

@amire80
Copy link
Contributor

amire80 commented Mar 18, 2018

Summary:

The message "Commons-android-strings-about rate us" is empty:
https://translatewiki.net/w/i.php?title=Special:Translations&message=Wikimedia%3ACommons-android-strings-about+rate+us%2Fhe

It should probably deleted, fixed, or ignored.

Steps to reproduce:

See translatewiki.

Expected behavior:

There must be no translatable messages in translatewiki that are empty strings.

@liuxinyu970226
Copy link

@ArkadiyVoronov
Copy link

Can I deal with this issue?

@misaochan
Copy link
Member

@ArkadiyVoronov it is yours. :)

@liuxinyu970226
Copy link

Found new one: Commons-android-strings-nominated see more

@liuxinyu970226
Copy link

liuxinyu970226 commented May 12, 2018

@liuxinyu970226
Copy link

@ArkadiyVoronov Commons-android-strings-nominated see more and Commons-android-strings-welcome help button text are still not fixed, please fix both!

@ArkadiyVoronov
Copy link

Hello! I will try to fix it

@maskaravivek
Copy link
Member

Thanks, @ArkadiyVoronov for picking this up. :)

@arshadkazmi42
Copy link

I can take this up if its still available. What exactly needs to be done here?

@maskaravivek
Copy link
Member

There have been no updates from @ArkadiyVoronov for over a month. So @arshadkazmi42 please feel free to take this up. :)

@arshadkazmi42
Copy link

@maskaravivek I am new to this project, just wanted to understand what exactly needs to be done here?

@misaochan
Copy link
Member

I think you just need to search for the relevant strings in strings.xml and delete it.

@misaochan
Copy link
Member

misaochan commented Aug 13, 2018

Edit: Ah, okay, I just checked the strings involved. Commons-android-strings-about rate us looks OK now as it has just had CDATA tags added, e.g. <![CDATA[<u>Rate us</u>]]>. Same with about-translate. The translation pages for those strings look OK to me as well, but I am not well-versed in translatewiki, can anyone confirm?

However, help_button does not have the CDATA tags added. The value is <u>More Information</u>, which will cause issues with translations.

So, what needs to be done in this task is:

  1. go to strings.xml and search for all strings that have a <u> tag added but no CDATA tag
  2. add the CDATA tag to those strings

@arshadkazmi42
Copy link

@misaochan Thanks for the detailed explanation I will look into it later today

@noloman
Copy link
Contributor

noloman commented Sep 14, 2018

hi! is anyone looking into this issue? @arshadkazmi42 are you going to check it out?

@arshadkazmi42
Copy link

@noloman
I think this was taken care at #1772

@Mansi449 was working on that issue.

@misaochan
Copy link
Member

Yes this seems to have been fixed, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants