Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no coordinates, ask where picture was taken #1848

Closed
nicolas-raoul opened this issue Aug 22, 2018 · 20 comments · Fixed by #4755
Closed

If no coordinates, ask where picture was taken #1848

nicolas-raoul opened this issue Aug 22, 2018 · 20 comments · Fixed by #4755

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Aug 22, 2018

Often GPS does not work, or is not enabled, and the picture has no coordinates, making it probably useless, see for instance https://commons.wikimedia.org/wiki/File:%D8%B5%D9%88%D8%B1%D8%A9_%D9%84%D9%82%D8%B1%D9%8A%D8%AA%D9%8A_.jpg

In such cases, we should ask the user where the picture was taken.

@misaochan
Copy link
Member

Why does this require Structured Commons?

@ioshomebrew
Copy link

Will work on the issue this week

@ioshomebrew
Copy link

And question, should I require users to enter a location in the event GPS is disabled?

@nicolas-raoul
Copy link
Member Author

@misaochan : When Structured Commons gets implemented, there will be a location field which will take as a value a Wikidata item, for instance https://www.wikidata.org/wiki/Q200126 (Paris 18). If we implement it now, we have to take the Wikidata item's P373 (Commons category) property. Nothing bad enough to justify postponing if you feel this feature is important, though :-)

@ioshomebrew
Thanks for volunteering!
Yes, even if GPS is disabled. Some people disable GPS for privacy reason, but they will probably be OK with specifying the location up to the level they are confortable with, for instance country or city.

Scenario:

  1. Ahmed upload a picture showing police misconduct, after striping all EXIF information via for his privacy.
  2. The app asks Ahmed for title/description/categories as usual.
  3. The app figures that Ahmed has not entered any category linked to a location.
  4. The app shows a list of continents, Ahmed chooses a continent.
  5. The app shows a list of countries, Ahmed chooses one.
  6. The app shows a list of regions, Ahmed chooses one.
  7. Etc. The levels may differ, for instance non-countries and regions containing other regions. Continents are hard-coded (https://www.wikidata.org/wiki/Q15 https://www.wikidata.org/wiki/Q18 https://www.wikidata.org/wiki/Q46 https://www.wikidata.org/wiki/Q48 https://www.wikidata.org/wiki/Q49 https://www.wikidata.org/wiki/Q51 https://www.wikidata.org/wiki/Q538) Countries are found using the P30 ("continent") property of items that are an instance of country. Lower levels are found using P131 ("located in the administrative territorial entity") property. Each level has a "Choose this location" button. Ahmed chooses https://www.wikidata.org/wiki/Q200126
  8. The app retrieves https://www.wikidata.org/wiki/Q200126 's P373 which is https://commons.wikimedia.org/wiki/Category:Paris_18e_arrondissement and adds that category to the picture.

Please let me know if you need help writing the SPARQL queries. Here is an example.

@nicolas-raoul nicolas-raoul changed the title If no GPS, ask where picture was taken If no coordinates, ask where picture was taken Aug 23, 2018
@VojtechDostal
Copy link
Collaborator

The idea with continents/countries etc is nice but quite complex... why wouldnt we just ask the uploader to pin a place in a google map/default map viewer and save that position?

@misaochan
Copy link
Member

misaochan commented Aug 23, 2018

Ah I see, thanks for the explanation @nicolas-raoul . I think this would be useful even before Structured Commons, probably. :)

I agree that pinning a place in a map would be ideal for the user, but not sure if we can utilize a 3rd party app for that purpose. We might potentially need to generate our own map (probably in a similar manner to how we call Mapbox for Nearby).

@ioshomebrew
Copy link

Progress Update: implemented location bar in upload page and requirement to add location

@nicolas-raoul
Copy link
Member Author

Cool! Don't hesitate to post early screenshots, and push your commits to your GitHub repo :-)

@ioshomebrew
Copy link

Just pushed some commits to my github repo, not finished yet, but getting close

@ioshomebrew
Copy link

@ioshomebrew
Copy link

Just discovered that in order to set the coordinates of a picture, I have to modify the metadata inside the image file itself

@nicolas-raoul
Copy link
Member Author

@ioshomebrew Any progress on this since your last commit (Sep 5, 2018)? Don't hesitate to push anything, even if not finished :-)

@nicolas-raoul
Copy link
Member Author

Re-reading this issue nearly a year later, I agree that putting a pin (or zooming/centering a place in the middle of the screen) sounds more developer-friendly and user-friendly.

At least for users who can read maps (before smartphones existed I remember walking around a city and asking local people where we are on a paper city map, many had no idea).

@NotSoImportant
Copy link

NotSoImportant commented Apr 10, 2021

As there is a separate wikidata entry for coordinates now, it should be offered to add and edit them.
IMHO same as #8.

By the way: as a contributor of openstreetmap I would love to see you choose openstreetmap for showing the map.
I am using the wikimedia commons app to upload images and link them to openstreetmap :-)

@nicolas-raoul
Copy link
Member Author

Good news, there is now a location picker in the Upload Wizard, it is the map icon at the top of the caption/description step.

I suggest making this location picker a fully-fledged Upload Wizard step for pictures that have no location.

@NotSoImportant
Copy link

Latest 3.1.1 release does not have it

@Ayan-10
Copy link
Contributor

Ayan-10 commented Dec 31, 2021

@nicolas-raoul I would like to work on it.

@nicolas-raoul
Copy link
Member Author

@NotSoImportant It is in master, so it will be in the next release 🙂

@Ayan-10 Thanks!

@Ayan-10
Copy link
Contributor

Ayan-10 commented Jan 15, 2022

I suggest making this location picker a fully-fledged Upload Wizard step for pictures that have no location.

@nicolas-raoul That means for those images which have no location there should be an extra step after description/caption where users are forced to pick a location using the location picker. Right?

@nicolas-raoul
Copy link
Member Author

@Ayan-10 Yes, exactly! Users should have a "Skip" button in case they do not want to pick a location, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants