-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If no coordinates, ask where picture was taken #1848
Comments
Why does this require Structured Commons? |
Will work on the issue this week |
And question, should I require users to enter a location in the event GPS is disabled? |
@misaochan : When Structured Commons gets implemented, there will be a location field which will take as a value a Wikidata item, for instance https://www.wikidata.org/wiki/Q200126 (Paris 18). If we implement it now, we have to take the Wikidata item's P373 (Commons category) property. Nothing bad enough to justify postponing if you feel this feature is important, though :-) @ioshomebrew Scenario:
Please let me know if you need help writing the SPARQL queries. Here is an example. |
The idea with continents/countries etc is nice but quite complex... why wouldnt we just ask the uploader to pin a place in a google map/default map viewer and save that position? |
Ah I see, thanks for the explanation @nicolas-raoul . I think this would be useful even before Structured Commons, probably. :) I agree that pinning a place in a map would be ideal for the user, but not sure if we can utilize a 3rd party app for that purpose. We might potentially need to generate our own map (probably in a similar manner to how we call Mapbox for Nearby). |
Progress Update: implemented location bar in upload page and requirement to add location |
Cool! Don't hesitate to post early screenshots, and push your commits to your GitHub repo :-) |
Just pushed some commits to my github repo, not finished yet, but getting close |
Just discovered that in order to set the coordinates of a picture, I have to modify the metadata inside the image file itself |
@ioshomebrew Any progress on this since your last commit (Sep 5, 2018)? Don't hesitate to push anything, even if not finished :-) |
Re-reading this issue nearly a year later, I agree that putting a pin (or zooming/centering a place in the middle of the screen) sounds more developer-friendly and user-friendly. At least for users who can read maps (before smartphones existed I remember walking around a city and asking local people where we are on a paper city map, many had no idea). |
As there is a separate wikidata entry for coordinates now, it should be offered to add and edit them. By the way: as a contributor of openstreetmap I would love to see you choose openstreetmap for showing the map. |
Good news, there is now a location picker in the Upload Wizard, it is the map icon at the top of the caption/description step. I suggest making this location picker a fully-fledged Upload Wizard step for pictures that have no location. |
Latest 3.1.1 release does not have it |
@nicolas-raoul I would like to work on it. |
@NotSoImportant It is in master, so it will be in the next release 🙂 @Ayan-10 Thanks! |
@nicolas-raoul That means for those images which have no location there should be an extra step after description/caption where users are forced to pick a location using the location picker. Right? |
@Ayan-10 Yes, exactly! Users should have a "Skip" button in case they do not want to pick a location, though. |
Often GPS does not work, or is not enabled, and the picture has no coordinates, making it probably useless, see for instance https://commons.wikimedia.org/wiki/File:%D8%B5%D9%88%D8%B1%D8%A9_%D9%84%D9%82%D8%B1%D9%8A%D8%AA%D9%8A_.jpg
In such cases, we should ask the user where the picture was taken.
The text was updated successfully, but these errors were encountered: