Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Nominate for deletion" shows wrong reasons in "Uploaded via mobile" #2657

Closed
nicolas-raoul opened this issue Mar 19, 2019 · 5 comments
Closed
Labels

Comments

@nicolas-raoul
Copy link
Member

In the new "Uploaded via mobile" tab of "Explore", I have found an off-topic picture, and as the "Nominate for deletion" button was visible I tapped it. Here is what appeared:
Screenshot_20190318-230646
As you can see, 4 of the reasons start with "I" which is a mistake since the picture was not uploaded by me.

I suggest using a different set of nomination reasons for pictures uploaded by others:

  • The picture has been downloaded from a random website
  • The uploader is not the author of the picture (copyright violation)
  • The picture is a selfie or joke
@vanshikaarora
Copy link
Collaborator

Hey, I am working on this!

@nicolas-raoul
Copy link
Member Author

Oh, actually I just got a better idea:
If the picture is not uploaded by me, it should not have a "nominate for deletion" button, but instead it should have a "Peer review" button that redirects to the Peer Review activity for that picture.
The Peer Review activity is not totally ready yet, but it should not change too much anymore so I suggest you create a feature branch and pull #2602 into it, and start integrating with it.
Thanks!

@vanshikaarora
Copy link
Collaborator

@nicolas-raoul I am suffering frequent crashes in the application after merging the PR.

Let's wait for the work completion. I'll pick this work whenever #2602 is merged with master

@mrudultora
Copy link
Contributor

Anyone working on this? If not, I would like to work on this.

@nicolas-raoul
Copy link
Member Author

Actually this is fixed now. Sorry for letting it open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants