Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer review picture blank in limited connection mode #3994

Closed
nicolas-raoul opened this issue Oct 27, 2020 · 9 comments · Fixed by #4247
Closed

Peer review picture blank in limited connection mode #3994

nicolas-raoul opened this issue Oct 27, 2020 · 9 comments · Fixed by #4247
Assignees

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Oct 27, 2020

Limited mode should either remove peer review from the menu, or load the pic under review (it is not that big)
Screenshot_20201027-171008_Commons

@Prince-kushwaha
Copy link
Contributor

@nicolas-raoul can i work on this issue

@Ankita13-code
Copy link

Ankita13-code commented Dec 21, 2020

Hey @nicolas-raoul! I'm new to contributing to wikimedia and would love to take this up as my first issue. Can this issue be assigned to me?

@nicolas-raoul
Copy link
Member Author

nicolas-raoul commented Dec 21, 2020

Prince, Ankita: This issue is quite hard, it will require some policy decisions. I would suggest finding another issue at https://github.com/commons-app/apps-android-commons/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+no%3Aassignee+-label%3Aassigned+-label%3Adebated+label%3Abug . Thanks!

@misaochan
Copy link
Member

I think removing Peer Review from the menu during limited connection mode would be the best solution, what do you think @sivaraam @nicolas-raoul ?

@nicolas-raoul
Copy link
Member Author

In my personal opinion, loading a miniature of 1 picture (I mean 1 by 1) is OK in limited connection, especially since opening Peer Review is voluntary.
But I totally agree with removing the menu entry until someone wants to implement that :-)

@mrudultora
Copy link
Contributor

@nicolas-raoul Can I work on this?

@nicolas-raoul
Copy link
Member Author

@mrudultora It is yours, thanks!
What approach will you take?

@mrudultora
Copy link
Contributor

@nicolas-raoul I am removing peer review from bottom sheet menu if the user is in limited connection mode. Is it fine ?

@nicolas-raoul
Copy link
Member Author

@mrudultora Sounds good :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants