Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nearby banner: Show item with no image #5448

Closed
nicolas-raoul opened this issue Jan 17, 2024 · 4 comments · Fixed by #5468
Closed

Nearby banner: Show item with no image #5448

nicolas-raoul opened this issue Jan 17, 2024 · 4 comments · Fixed by #5468

Comments

@nicolas-raoul
Copy link
Member

The Nearby banner currently shows the nearest Wikidata item.

Instead, I think it should show the nearest Wikidata item with no image.

Merits:

  • Get users to take the most needed pictures
  • After the user uploads the item, the banner will start showing a different item, rather than still showing the same one which is uninteresting.
@shashankiitbhu
Copy link
Contributor

I believe I can work on this issue, can you assign this to me?

@shashankiitbhu
Copy link
Contributor

@nicolas-raoul Please Review #5468

@nicolas-raoul
Copy link
Member Author

Ah, sorry for not mentioning this at first, but would you mind also ignoring items that do not exist? Bonus if you can reuse the logic found behind the Nearby activity "Exists" checkbox.

@shashankiitbhu
Copy link
Contributor

Sure, will make these changes in the next commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants