[Bug]: Can't Open Privacy Policy

[shashankiitbhu]

Summary

Unable to Open the Privacy Policy on the app's login page. This can become a hurdle in getting the app Reviewed in Release as Play Store Guidelines require there to be an accessible privacy policy, this can lead to app update getting rejected too.

Steps to reproduce

1. Open the app
2. Logout if you are logged in
3. click on "Privacy Policy"

Expected behaviour

Privacy Policy Opens in a Web View

Actual behaviour

Misleading Error Message

Device name

Xaomi 11 Lite NE

Android version

13

Commons app version

4.2.1-debug-main

Device logs

No response

Screen-shots

WhatsApp.Video.2024-02-09.at.1.57.23.PM.mp4

Would you like to work on the issue?

Yes

[kanahia1]

Hey @shashankiitbhu it is working fine for me 😀

Screen_Recording_20240209_143711_Chrome.mp4

[nicolas-raoul]

Thanks both for the feedback!

This link is important so it should be fixed to work on all devices.

@shashankiitbhu would you mind installing some intent interceptor tool and checking what intent is sent? Do you have any other app where such links work? If yes please post these intents too, in order to compare. Thanks a lot! :-)

[rohit9625]

Hey @shashankiitbhu it is working fine for me 😀

Screen_Recording_20240209_143711_Chrome.mp4

Did you tried it on a latest branch?

[shashankiitbhu]

@rohit9625 Yes, I am looking into this issue - to find out if it's device specific

[shashankiitbhu]

@nicolas-raoul I Found out that this issue was due to the fact that I had Github Mobile App Installed which expects deep links like the link we are using for Privacy Policy but a conditional check in handleWebUrl Method was returning the method after checking if the link opens in a browser or not (Which is misleading for cases like this), for example, if we try to open Wikipedia link but Wikipedia App is already installed (assuming deep links are set up in Wikipedia app) then it would cause the same issue as this one

[ShashwatKedia]

@nicolas-raoul I Found out that this issue was due to the fact that I had Github Mobile App Installed which expects deep links like the link we are using for Privacy Policy but a conditional check in handleWebUrl Method was returning the method after checking if the link opens in a browser or not (Which is misleading for cases like this), for example, if we try to open Wikipedia link but Wikipedia App is already installed (assuming deep links are set up in Wikipedia app) then it would cause the same issue as this one

Um, @shashankiitbhu, I also have the GitHub Mobile app installed on my device, but I am still able to open the privacy policy from my device, and it successfully opens in the GitHub mobile app itself.

[shashankiitbhu]

@ShashwatKedia That's Interesting, can you tell me more about your Android Version and API Level, Deep Links or App Links Behave differently on different API levels , I would love to investigate this more

[ShashwatKedia]

@shashankiitbhu Sure! My device is a OnePlus Nord CE 2 Lite, running API level 31. It's nice to see that you are so much interested in investigating deep into the issue :)

[shashankiitbhu]

@ShashwatKedia This Issue is tested well on a Device with API Level 33 (or Android version 13) and I have also found other Deep Link (App Link) Issues with this API Level (on other Projects). It seems to work fine with older API Levels. Hence, The Proposed solution is for devices running on API Level 33, Thanks :)

[shashankiitbhu]

WhatsApp.Video.2024-02-10.at.11.49.07.AM.mp4

As you can see here the app directly stops the Privacy Policy Url from opening

[nicolas-raoul]

I merged for now, everyone who had the issue please try and let us know here, thanks! :-)