-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
values-yue-hant: Resource and asset merger: Invalid resource directory name #5571
Comments
Anyone interested in this issue? |
I'll work on it, was waiting for newcomers to try it as it's a good first issue. |
@nicolas-raoul For me renaming the directory seems to work fine and I am able to build and run apk without any issues, Should I make a PR ? |
@nicolas-raoul Kindly give this work to me, I shall do it. |
Did a well go through I have two proposed solution. While I was installing the project locally I faced the issue.
values-yue-hant is basically used for Cantonese speakers who read Traditional Chinese characters. But the issue here arises is that Android's resource management system may not recognize We already have resource
Create two directory for simplified and traditional and include all region from it, @nicolas-raoul What do you think of it? I did checked #5573 so if removing |
Even if we move or remove it, the folder will be recreated by translatewiki. The most importnt is to modify the translatewiki configuration in gerrit, see similar issue in initial description. |
As it represents |
I added a commit on Gerrit - https://gerrit.wikimedia.org/r/c/translatewiki/+/1007685 |
@rohit9625 Wonderful, thanks for performing the change on Gerrit! :-) |
I made the new changes and sorry I didn't notice that at first. |
Do I need to link a PR because I didn't make any changes to the files on my PC? |
Thanks for posting the link https://gerrit.wikimedia.org/r/c/translatewiki/+/1007685 that's enough. :-) |
Very similar past fix:
#5040
https://gerrit.wikimedia.org/r/c/translatewiki/+/826587
Good issue for someone familiar with Gerrit, just mimic the fix above.
Workaround for anyone trying to build: Remove that folder.
The text was updated successfully, but these errors were encountered: