Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

values-yue-hant: Resource and asset merger: Invalid resource directory name #5571

Closed
nicolas-raoul opened this issue Feb 24, 2024 · 12 comments
Closed

Comments

@nicolas-raoul
Copy link
Member

nicolas-raoul commented Feb 24, 2024

> Task :app:mergeProdDebugResources FAILED
ERROR: /Users/nicolasraoul/src/commons-app/app/src/main/res/values-yue-hant: Resource and asset merger: Invalid resource directory name

Very similar past fix:
#5040
https://gerrit.wikimedia.org/r/c/translatewiki/+/826587

Good issue for someone familiar with Gerrit, just mimic the fix above.

Workaround for anyone trying to build: Remove that folder.

@nicolas-raoul
Copy link
Member Author

Anyone interested in this issue?
Good opportunity to experience Gerrit with a tiny change. :-)

@shashankiitbhu
Copy link
Contributor

I'll work on it, was waiting for newcomers to try it as it's a good first issue.

@shashankiitbhu
Copy link
Contributor

@nicolas-raoul For me renaming the directory seems to work fine and I am able to build and run apk without any issues, Should I make a PR ?

@abhinandan-verma
Copy link

@nicolas-raoul Kindly give this work to me, I shall do it.

@neeldoshii
Copy link
Contributor

neeldoshii commented Feb 29, 2024

Did a well go through I have two proposed solution.

While I was installing the project locally I faced the issue.

AGPBI: {"kind":"error","text":"Invalid resource directory name",
Execution failed for task ':app:mergeBetaDebugResources'.
> /project-directory/apps-android-commons/app/src/main/res/values-yue-hant: Error: Invalid resource directory name

values-yue-hant is basically used for Cantonese speakers who read Traditional Chinese characters. But the issue here arises is that Android's resource management system may not recognize values-yue-hant.

image

We already have resource zh-rHK & zh-rTW
For values-zh-rHK, focus on Cantonese-specific wording. For values-zh-rTW, focus on standard Traditional Chinese.

  1. There is no need for redundant value-yue-hant and can be elimated is the first proposed solution.

  2. The second thing which we can do is

image

Create two directory for simplified and traditional and include all region from it,

@nicolas-raoul What do you think of it? I did checked #5573 so if removing value-yue-hant is not the recommended solution then we can move to 2nd proposed solution.
Correct me if I am wrong.
Also can I get assigned to this issue?

@nicolas-raoul
Copy link
Member Author

Even if we move or remove it, the folder will be recreated by translatewiki.

The most importnt is to modify the translatewiki configuration in gerrit, see similar issue in initial description.

@rohit9625
Copy link
Contributor

As it represents Cantonese Chinese. So, I think we should replace it with values-yue.

@rohit9625
Copy link
Contributor

I added a commit on Gerrit - https://gerrit.wikimedia.org/r/c/translatewiki/+/1007685

@nicolas-raoul
Copy link
Member Author

@rohit9625 Wonderful, thanks for performing the change on Gerrit! :-)

@rohit9625
Copy link
Contributor

I made the new changes and sorry I didn't notice that at first.

@rohit9625
Copy link
Contributor

Do I need to link a PR because I didn't make any changes to the files on my PC?

@nicolas-raoul
Copy link
Member Author

Thanks for posting the link https://gerrit.wikimedia.org/r/c/translatewiki/+/1007685 that's enough. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants