Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Sub Categories and Parent Categories should be shown if available #5626

Open
rohit9625 opened this issue Mar 16, 2024 · 3 comments
Open
Assignees
Labels

Comments

@rohit9625
Copy link
Contributor

Summary

When I browse the category on a details page of an upload, I see the blank sub-categories and parent categories page. For some categories, there are no sub and parent-categories available. So in that case, we should display a message(e.g. using Snackbar or maybe just showing text in the middle of the screen). Also, the screen is still blank for some categories despite having sub-categories available on the category page.

Steps to reproduce

  1. Open any image(self uploaded or from the Explore tab) details page
  2. Click on any category from the Categories section
  3. Switch to sub-categories tab
  4. You'll see a blank screen even sub-categories are available on the category page

Expected behaviour

There should be a message similar to this No sub-categories available, if not available. And should show the sub-categories list if available.

Actual behaviour

The screen is blank with no response message.

Device name

SAMSUNG A14

Android version

ANDROID 14

Commons app version

4.2.1

Device logs

No response

Screen-shots

WhatsApp Image 2024-03-16 at 09 12 43_a5f2568e
WhatsApp Image 2024-03-16 at 09 12 43_a418479e

Category Page
WhatsApp Image 2024-03-16 at 09 12 42_f5c05f2b

Would you like to work on the issue?

Yes

@nicolas-raoul
Copy link
Member

I would say showing text in the middle of the screen is the best, rather than a snackbar :-)

@mnalis
Copy link
Contributor

mnalis commented Apr 13, 2024

Doesn't it already say No subcategories found ? E.g. in latest F-droid release 4.2.1~14b6c455b on Android 14:

small_Screen_Recording_20240413_194021_Commons.mp4

Perhaps it only happens in some specific cases? Of I misunderstood how to reproduce it?

@nicolas-raoul
Copy link
Member

Somehow category search isn't even working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants