Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When "Show already actioned pictures" disabled, Custom picker does not check uploaded-or-not status for never seen pics #5649

Open
nicolas-raoul opened this issue Mar 25, 2024 · 2 comments

Comments

@nicolas-raoul
Copy link
Member

  1. Reset the app
  2. Download https://upload.wikimedia.org/wikipedia/commons/4/4c/Bar-bellied_Pitta.jpg
  3. Start the app
  4. Open custom picker
  5. Tap your "Camera" album (not "Download")
  6. Disable "Show already actioned pictures"
  7. Go back
  8. Tap your "Download" folder
  9. Problem: tHe Pitta pic shows up, even though it is already on Commons.

It seems like the app only verifies checksums when "Show already actioned pictures is enabled.

@rohit9625
Copy link
Contributor

It's barely repeatable for me. At first, it behaved just like you described, but in the second and all after trials, it just worked like it needed to be. Even after show actioned pictures was disabled, the image didn't show up.
That means the app verifies the checksum when that switch is disabled.

@nicolas-raoul
Copy link
Member Author

Example on latest main branch, even though "show already actioned images" is disabled, the already uploaded "pachinko" picture is shown. Then after enabling the switch the app finally does the proper checksum API call.

screen-20240401-120502.2.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants