Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location button UI not being updated when user clicks yes in similar image dialog #5669

Open
ShashwatKedia opened this issue Mar 28, 2024 · 8 comments

Comments

@ShashwatKedia
Copy link
Contributor

Summary

The app currently has a feature where the user can copy the location of a recently uploaded image to the new set of images being uploaded. The current image's 'Add location' button should change to 'Edit location' when the user clicks yes in the aforesaid dialog.

Steps to reproduce

  1. Start upload of an image having EXIF data
  2. Cancel its upload and start upload of another set of images without EXIF data within two minutes
  3. Tap "Yes" in the similar image dialog

Expected behaviour

The current image's 'Add location' button should change to 'Remove location' with the icon also changing accordingly, as the image now has location data, which can be verified by tapping the button.

Actual behaviour

The current image's 'Add location' button UI stays the same.

Device name

OnePlus Nord CE 2 Lite 5G

Android version

Android 12

Commons app version

master

Device logs

No response

Screen-shots

Screencast:

video6064299869818851037.mp4

Would you like to work on the issue?

None

@ShashwatKedia
Copy link
Contributor Author

@nicolas-raoul, could this issue be labelled as a 'good first issue' for newcomers to try?

@nicolas-raoul
Copy link
Member

Thanks for spotting this bug! OK done :-)

@alxmartin01
Copy link

I would like to work on this! Can I be assigned?

@nicolas-raoul
Copy link
Member

@alxmartin01 It is yours, thanks! 🙂

@AMANISPEACE
Copy link

Hey, Could you please assign me this issue, Would like to work on that.

@nicolas-raoul
Copy link
Member

@alxmartin01 Any progress to share? Are you still working on this? :-)

@nishit2003
Copy link

Can I work on it?

@nicolas-raoul
Copy link
Member

@AMANISPEACE and @nishit2003 Please use the "unassigned bugs" link at https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md to find other tasks that are waiting for someone to take care of them, thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants