Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nearby -> Custom picker: Only allow 1 picture to be selected #5674

Open
nicolas-raoul opened this issue Mar 30, 2024 · 9 comments
Open

Nearby -> Custom picker: Only allow 1 picture to be selected #5674

nicolas-raoul opened this issue Mar 30, 2024 · 9 comments

Comments

@nicolas-raoul
Copy link
Member

Currently several pictures can be selected, which is not OK from a Wikidata point of view.

@rohit9625
Copy link
Contributor

Okay, I got it :)
But one question. By Custom Picker, did you mean this, Mr. Nicolas?
WhatsApp Image 2024-03-30 at 19 14 51_dcc5ec51

If yes, then I would like to work on this task.

@ShashwatKedia
Copy link
Contributor

@rohit9625 I think by custom picker Nicolas means the custom gallery in the app which can be accessed from the Nearby section, which looks something like this:

Custom picker

There are 2 ways to access this: first from the contributions screen (+) and a second from the nearby when you click on a pin near you then you see a (+)

@rohit9625
Copy link
Contributor

Yes, I tried opening this from Nearby fragment but I got only these two options:
WhatsApp Image 2024-03-30 at 19 37 18_a5b8b692

@nicolas-raoul
Copy link
Member Author

It is a recent improvement, only available on lastest main branch.

@ShashwatKedia
Copy link
Contributor

@nicolas-raoul, just a small doubt: why should we not allow users to upload multiple images? Let's say the user wants to upload multiple angles of the nearby place.

@nicolas-raoul
Copy link
Member Author

Each Wikidata item should have at most one P18 property. The picture that best represents it. The other images that represent the same item can be linked to it as "depictions".

@rohit9625
Copy link
Contributor

So, should we also need to allow for 1 picture to be selected from the selector that is on the screenshot I uploaded?

@nicolas-raoul
Copy link
Member Author

@rohit9625 Yes totally! If no issue exists about this yet, you may want to create one indeed. :-)

@rohit9625
Copy link
Contributor

Okay 👍, I will start working on the current one first.
Also, now I am getting the custom-selector option at the Nearby, Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants