Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely do away with the doNotAskForLocationPermission global state #5678

Open
sivaraam opened this issue Mar 30, 2024 · 1 comment
Open
Assignees

Comments

@sivaraam
Copy link
Member

We have a global state in our app with the key doNotAskForLocationPermission. It seems to be complicate understanding of the code flow more difficult than it should be. We need to explore ways to completely remove the same and handle it in other ways that are more maintainable.

The following is the PR comment that led to the creation of this issue: #5494 (comment)

That PR seems to already reduce our dependence on the doNotAskForLocationPermission global state to some extent. This issue is about refactoring the code such that we no longer need it at all. Feel free to propose solutions that could help us achieve this.

@ShashwatKedia
Copy link
Contributor

@sivaraam I would like to work on this issue and propose a solution as soon as the PR linked in the comment gets merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants