Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Unknown on pointer click to ... (Nearby Activity) #5690

Closed
kanahia1 opened this issue Apr 14, 2024 · 5 comments · Fixed by #5697
Closed

Change Unknown on pointer click to ... (Nearby Activity) #5690

kanahia1 opened this issue Apr 14, 2024 · 5 comments · Fixed by #5697

Comments

@kanahia1
Copy link
Contributor

Since on the pointer click in the Nearby Activity shows description as Unknown which is pretty confusing, We should probably change it to something else. Suggestions are welcome :-)

WhatsApp Image 2024-04-14 at 11 38 03_c902a97b

@RitikaPahwa4444
Copy link
Collaborator

Something like No description available would indeed provide more context about what we're trying to portray here.

@kanahia1
Copy link
Contributor Author

Hey @RitikaPahwa4444, Description is hardcoded to null that's why it showing Unknown for every pointer. I am looking for suggestions to change the hardcoded string to something else.

https://github.com/commons-app/apps-android-commons/blob/8ce7485153c4e9b5aea6b07d582c683e2ca34861/app/src/main/java/fr/free/nrw/commons/nearby/fragments/NearbyParentFragment.java#L1803C5-L1814C10

@RitikaPahwa4444
Copy link
Collaborator

Got it, thanks for clarifying! I thought it's just happening for the cases when we don't have any description.

@nicolas-raoul
Copy link
Member

I circled in red info that might be useful to display instead of "Unknown":

Screenshot_20240416-162416.png

How about the bottom one? (Wikidata description)

@kanahia1
Copy link
Contributor Author

Wikidata description seems great 👍 I will share a Pull Request asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants