Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate searcher.py in favor of the Go client? #2

Open
sylvinus opened this issue Feb 20, 2016 · 2 comments
Open

Deprecate searcher.py in favor of the Go client? #2

sylvinus opened this issue Feb 20, 2016 · 2 comments

Comments

@sylvinus
Copy link
Contributor

Still not sure if we should entirely remove searcher.py

It's only used in tests. If we remove it we'd have to make at least the cosr-back tests depend on the cosr-front code.

Pros:

  • Less code duplication/maintenance
  • Less risk of subtle diffs that would make debugging hard.

Cons:

  • More complex setup
  • Unnatural dependency between both projects
  • One more language to understand for people willing to contribute
@sylvinus
Copy link
Contributor Author

Actually I find it somewhat practical and maybe even beneficial to iterate on the Python code, break tests, tweak things, and then freeze the code in the Go client. It is a bit more work, but not that bad.

@chris-heney
Copy link

I agree with interactive dev/design principles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants