Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API docs: add Job Suspension operation & also add all the missing Archive and Systems API endpoints #18

Open
jsyrjala opened this issue Jan 23, 2021 · 4 comments

Comments

@jsyrjala
Copy link

Wiki talks about PATCH call to /systems/:system/jobs/:jobid in https://github.com/mikub/titanoboa/wiki/Designing-Workflows#suspendable but API docs do not mention them (https://github.com/mikub/titanoboa/wiki/API-Documentation)

@jsyrjala
Copy link
Author

Also is there a Swagger/OpenAPI description available?

@mikub
Copy link
Contributor

mikub commented Jan 23, 2021

Hi @jsyrjala ,
yep the API documentation needs some updating, apart the recent addition pf suspending/resuming jobs there is also a need to add API docs for systems operations (starting/stopping system & workers etc.).
I should be able to do that soon.
In the meantime handler.clj https://github.com/mikub/titanoboa/blob/master/src/clj/titanoboa/handler.clj could be used as the source of truth (which of course is not ideal).

I am not a big fan of swagger but defo it is worth considering or looking at some alternatives.

Cheers
Miro

@mikub
Copy link
Contributor

mikub commented Jan 23, 2021

I added first note regarding suspension: https://github.com/mikub/titanoboa/wiki/API-Documentation#suspend-a-running-workflow-job
Will also add API docs for systems and also archive.

@mikub mikub changed the title API request missing from docs? Update API docs: add Job Suspension operation & also add all the missing Archive and Systems API endpoints Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants