Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[test] attribute doesn't work correctly if used in front of #[datatest::..] #5

Open
idubrov opened this issue May 8, 2019 · 0 comments

Comments

@idubrov
Copy link
Contributor

idubrov commented May 8, 2019

Currently, the way #[test] is handled is proc macro deletes it when processing datatest attribute.

There are two reason #[test] attribute is desirable:

  1. Better integration with IDEs which don't know about #[datatest], but can handle #[test] (for example, allow running test by clicking on it). I use IntelliJ as a test bed 😛
  2. Differentiation between test tests and bench tests.

The issue is that if #[test] goes first, it will be handled by Rust built-in test harness, which is undesirable. Need to figure out a way to disable that -- potentially, #4 will solve that, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant