Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(husky): add husky and conventional commits as standard #35

Merged
merged 3 commits into from Oct 18, 2022

Conversation

comoser
Copy link
Owner

@comoser comoser commented Oct 18, 2022

Description

  • Add husky and commit-msg hook
  • Enforce conventional commits for the repo
  • Fix name for PR template in the repo

Related Issue

Closes #29

Motivation and Context

This change will improve commit consistency and improve readability when searching the commit history

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@comoser comoser changed the title chore(husky): Add husky and conventional commits as standard chore(husky): add husky and conventional commits as standard Oct 18, 2022
Copy link
Collaborator

@tiagomichaelsousa tiagomichaelsousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also add this validation to the PR's titles with a workflow, what do you think? 👀

@comoser
Copy link
Owner Author

comoser commented Oct 18, 2022

We can also add this validation to the PR's titles with a workflow, what do you think? 👀

That would be awesome! Want to create the issue? 🙏

@comoser comoser merged commit a1b74e0 into main Oct 18, 2022
@comoser comoser deleted the feat/#29-setup-husky-conventional-commits branch October 18, 2022 14:03
@tiagomichaelsousa
Copy link
Collaborator

We can also add this validation to the PR's titles with a workflow, what do you think? 👀

That would be awesome! Want to create the issue? 🙏

Already did #38 😎

Do you want me to create the issues for the release drafter and label checker as well?

@comoser
Copy link
Owner Author

comoser commented Oct 18, 2022

We can also add this validation to the PR's titles with a workflow, what do you think? 👀

That would be awesome! Want to create the issue? 🙏

Already did #38 😎

Do you want me to create the issues for the release drafter and label checker as well?

Please do!! 🙏🙏

@tiagomichaelsousa tiagomichaelsousa added the feature New feature or request label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup husky to only allow conventional commits on the repository
2 participants