Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor id out from @attribute #7

Closed
thhermansen opened this issue Dec 14, 2010 · 1 comment
Closed

Refactor id out from @attribute #7

thhermansen opened this issue Dec 14, 2010 · 1 comment
Labels
feature orm

Comments

@thhermansen
Copy link
Contributor

I don't think its 100% correct to store id in @attributes. I don't think ActiveRecord does it, and it for sure don't include id when attributes() are called.
@thhermansen
Copy link
Contributor Author

Never mind. Had I used my eyes in the first place I'd notice that the id indeed is included in attributes(). What we might want to consider is implementing protected_attributes so that the id (and other attributes) can't be mass-assigned.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature orm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thhermansen