brclient: persist PM/GCM msgs for clientrpc #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 9, 2023 19:01
This makes calls to stream.Send() functions block until the message has actually been sent on the wire. This change makes sending a notification a synchronous event relative to the connection, making it easier to reuse the object being sent, since it's guaranteed to be available for use.
This fixes a bug that happened on the client side of a stream, when multiple messages were received and queued for processing in a short time. The queue elements were not properly popped, causing the first element to be processed multiple times. A test is added to lock in the correct behavior.
The replaymsglog is meant to hold messages temporarily for the rpcserver, while the consumer for the messages is offline.
This adds the necessary messages and methods to control the replaymsglog feature for PMs and GCMs in the client's RPC server. In particular, it allows fetching unacked messages from the server when initializing a stream and also to ack processed messages to remove them from the replaymsg store. The client rpcserver implementation is modified with dummy implementation for the methods.
This adds the implementations to the replaymsglog feature in the client's RPC server. brclient is modified to setup the replaymsglog within the client db dir.
This demonstrates how to use the ack feature to fetch messages received while the clientrpc client was offline.
added 5 commits
February 9, 2023 19:08
It was incorrectly derived from the ID instead of nick.
dajohi
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this stores received msgs (PMs and GCms) in a message store so that clientrpc clients may retrieve them, which prevents missed messages in bots and other automation tools.