bruig: Save and read sorted chat lists order #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
changed the title
miki-totefu
reviewed
Jan 27, 2023
| } | ||
| if (value.length > 0) { | ||
| var splitList = value.split(','); | ||
| } |
miki-totefu
reviewed
Jan 27, 2023
miki-totefu
reviewed
Feb 6, 2023
Comment on lines
+376
to
+420
| for (int i = 0; i < _gcChats.length; i++) { | ||
| var found = false; | ||
| for (int j = 0; j < gcSplitList.length; j++) { |
There was a problem hiding this comment.
this is backwards
you need to first iterate the saved list, to add the chats in sortedGCList in the order they were saved
same for users
alexlyp
force-pushed
the
ayp_save_list_order
branch
from
afadfbd
to
9854e00
Compare
miki-totefu
approved these changes
Feb 9, 2023
alexlyp
force-pushed
the
ayp_save_list_order
branch
from
b13d064
to
ca61d6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.