New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track and reset KX with long offline users #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that prevented client shutdown if the client failed to completely initialize during address book loading.
This ensures files that are unlikely to be KX files are not loaded during startup.
This is added to the /addressbook command, as an optional argument to display the addressbook entry of a particular user.
This resets all clients with ratchets that have not received messages in a given age.
This allows showing the last time a message was received from all users.
This adds a check after connecting to the server to verify if the local client has been offline for longer than the server's message retention policy. If true, then the client sends a reset KX command to all known users. This is needed to prevent a situation where, after being offline for too long, all of the client's ratchets are broken due to lost messages.
Instead of using a fixed 7-day interval, use the server expiration policy.
miki-totefu
force-pushed
the
autorekx
branch
7 times, most recently
from
February 2, 2023 17:18
521d264
to
4f72c3d
Compare
Improves performance when there are many KXs.
Needed to debug test failures
Also add a confirmation modal to the block user action.
dajohi
approved these changes
Feb 14, 2023
miki-totefu
force-pushed
the
autorekx
branch
from
February 14, 2023 18:11
afeb642
to
7da4b8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes tracking and performing KX reset actions with users from which messages have not been received for some time easier.