client: track and warn unsupported GC version #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
approved these changes
Feb 23, 2023
added 2 commits
February 23, 2023 13:41
This adds a new Version field in GC definitions and warns the user when a GC list with an unsupported version is received. This will be used in the future to warn about upgraded GCs. The current GC version is assumed to be version 0. A function is added in the clients to resend the GC list, to fix issues with the list getting out of sync in members.
miki-totefu
force-pushed
the
gcversion
branch
from
8fe1b66
to
e8a8733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new Version field in GC definitions and warns the user when
a GC list with an unsupported version is received. This will be used in
the future to warn about upgraded GCs.
The current GC version is assumed to be version 0.
A function is added in the clients to resend the GC list, to fix issues
with the list getting out of sync in members.
Test by modifying client.ResetGCList to send a different version.